virajjasani commented on a change in pull request #1684:
URL: https://github.com/apache/hbase/pull/1684#discussion_r422339899
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java
##########
@@ -163,7 +164,16 @@ public void
testMasterShutdownBeforeStartingAnyRegionServer() throws Exception {
assertNotEquals("Timeout waiting for server manager to become
available.",
-1, Waiter.waitFor(htu.getConfiguration(), timeout,
() -> masterThread.getMaster().getServerManager() != null));
- htu.getConnection().getAdmin().shutdown();
+ try {
+ htu.getConnection().getAdmin().shutdown();
Review comment:
Btw the root cause that I have seen for the above Exception:
```
2020-05-09 00:58:39,957 ERROR
[RpcServer.priority.RWQ.Fifo.read.handler=1,queue=1,port=53033]
master.HMaster(2878): ZooKeeper exception trying to set cluster as down in ZK
org.apache.zookeeper.KeeperException$SystemErrorException: KeeperErrorCode =
SystemError
at
org.apache.hadoop.hbase.zookeeper.ZKWatcher.interruptedException(ZKWatcher.java:626)
at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:1285)
at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:1269)
at
org.apache.hadoop.hbase.zookeeper.ClusterStatusTracker.setClusterDown(ClusterStatusTracker.java:84)
at org.apache.hadoop.hbase.master.HMaster.shutdown(HMaster.java:2876)
at
org.apache.hadoop.hbase.master.MasterRpcServices.shutdown(MasterRpcServices.java:1630)
at
org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:395)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)
Caused by: java.lang.InterruptedException
at java.lang.Object.wait(Native Method)
at java.lang.Object.wait(Object.java:502)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1529)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1512)
at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:1791)
at
org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:171)
at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:1280)
... 9 more
2020-05-09 00:58:39,957 DEBUG [Time-limited test-EventThread]
zookeeper.ZKWatcher(490): master:53033-0x1000d0785dd0000,
quorum=127.0.0.1:60460, baseZNode=/hbase Received ZooKeeper Event,
type=NodeDeleted, state=SyncConnected, path=/hbase/master
2020-05-09 00:58:39,957 INFO [M:0;172.20.10.2:53033]
regionserver.HRegionServer(1119): stopping server
172.20.10.2,53033,1588966118448; all regions closed.
2020-05-09 00:58:39,958 INFO [M:0;172.20.10.2:53033]
hbase.ChoreService(329): Chore service for: master/172.20.10.2:0 had [] on
shutdown
2020-05-09 00:58:39,958 DEBUG [M:0;172.20.10.2:53033] master.HMaster(1516):
Stopping service threads
```
Does not look like issue with moving code to registry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
