[
https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124691#comment-17124691
]
Duo Zhang commented on HBASE-24492:
-----------------------------------
OK, checked the code, there is a 'return true' at the last of the while(true)
loop, and there is no continue statement in the middle, so I agree with you
that the loop is useless.
+1 on removing it.
[~stack] I think this could go into all 2.x branches? Just a code clean.
> ProtobufLogReader.readNext does not need looping
> ------------------------------------------------
>
> Key: HBASE-24492
> URL: https://issues.apache.org/jira/browse/HBASE-24492
> Project: HBase
> Issue Type: Task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> ProtobufLogReader.readNext is using infinite while loop for the whole method,
> however it returns value or throws errors in single execution. while(true)
> was part of initial code and with better improvements in the method, this
> loop has not been removed yet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
