[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125088#comment-17125088 ]
Viraj Jasani commented on HBASE-24492: -------------------------------------- No worries. Although I am quite certain that it's not going to make any difference execution wise, I am not in favor of putting more burden on one of the cleanest(feature heavy but 0 flakes :) ) upcoming release 2.3. Let me close this Jira. [~zhangduo] maybe I can revisit this for committing to all 2.x branch after releasing 2.3.0. Sounds good to you? > ProtobufLogReader.readNext does not need looping > ------------------------------------------------ > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task > Components: Replication, wal > Reporter: Viraj Jasani > Assignee: Viraj Jasani > Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)