[
https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124695#comment-17124695
]
Viraj Jasani commented on HBASE-24492:
--------------------------------------
Thanks [~zhangduo]
Exactly the loop is useless and confusing for readers. When I came here, I
started searching for howmany times this could loop, ran some tests and then
suddenly realized, this is not at all looping.
> ProtobufLogReader.readNext does not need looping
> ------------------------------------------------
>
> Key: HBASE-24492
> URL: https://issues.apache.org/jira/browse/HBASE-24492
> Project: HBase
> Issue Type: Task
> Components: Replication, wal
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> ProtobufLogReader.readNext is using infinite while loop for the whole method,
> however it returns value or throws errors in single execution. while(true)
> was part of initial code and with better improvements in the method, this
> loop has not been removed yet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
