bitoffdev commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r445838230
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -971,101 +976,103 @@ def enabled?(table_name)
end
#----------------------------------------------------------------------------------------------
- # Return a new HColumnDescriptor made of passed args
- def hcd(arg, htd)
+ # Return a new ColumnFamilyDescriptor made of passed args
+ def hcd(arg, tdb)
# String arg, single parameter constructor
- return org.apache.hadoop.hbase.HColumnDescriptor.new(arg) if
arg.is_a?(String)
+
+ return ColumnFamilyDescriptorBuilder.of(arg) if arg.is_a?(String)
raise(ArgumentError, "Column family #{arg} must have a name") unless
name = arg.delete(NAME)
- family = htd.getFamily(name.to_java_bytes)
+ cfd = tdb.build.getColumnFamily(name.to_java_bytes)
Review comment:
I think that if we do choose to add any sort of introspection (like
hasColumnFamily, getColumnFamily) to the TableDescriptorBuilder itself, that
would belong in a separate ticket/issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
