busbey commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r445878539
##########
File path: hbase-shell/src/main/ruby/hbase_constants.rb
##########
@@ -109,8 +109,8 @@ def self.promote_constants(constants)
end
end
- promote_constants(org.apache.hadoop.hbase.HColumnDescriptor.constants)
- promote_constants(org.apache.hadoop.hbase.HTableDescriptor.constants)
+
promote_constants(org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.constants)
Review comment:
Hurm. Some of those still look likely to be useful (e.g.
MOB_THRESHOLD_BYTES). Can we add them in without bringing back references to
the classes we're removing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
