bitoffdev commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r446296466
##########
File path: hbase-shell/src/main/ruby/hbase_constants.rb
##########
@@ -109,8 +109,8 @@ def self.promote_constants(constants)
end
end
- promote_constants(org.apache.hadoop.hbase.HColumnDescriptor.constants)
- promote_constants(org.apache.hadoop.hbase.HTableDescriptor.constants)
+
promote_constants(org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.constants)
Review comment:
I just pushed a commit that adds back three constants, but leaves the
rest out. I left a [comment on
Jira](https://issues.apache.org/jira/browse/HBASE-20819?focusedCommentId=17146470#comment-17146470)
with my rationale for each of the constants. **Let me know if you disagree
with any of my conclusions, and I can easily add more constants back** 😄.
Specifically for the [MOB
constants](https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptorBuilder.java#L163),
we added setters for all the MOB key-value pairs to our builder. I think
including these _private_ constants will encourage users to go against our
defined interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
