apurtell commented on a change in pull request #2261: URL: https://github.com/apache/hbase/pull/2261#discussion_r475896191
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/LogQueryFilter.java ########## @@ -22,22 +22,27 @@ import org.apache.commons.lang3.builder.EqualsBuilder; import org.apache.commons.lang3.builder.HashCodeBuilder; import org.apache.commons.lang3.builder.ToStringBuilder; +import org.apache.hadoop.hbase.ServerName; import org.apache.yetus.audience.InterfaceAudience; +import org.apache.yetus.audience.InterfaceStability; +import java.util.Collections; +import java.util.Set; /** * Slow/Large Log Query Filter with all filter and limit parameters * Used by Admin API: getSlowLogResponses */ [email protected] -public class LogQueryFilter { [email protected] [email protected] +public class LogQueryFilter extends LogRequest { private String regionName; private String clientAddress; private String tableName; private String userName; - private int limit = 10; Review comment: This change doesn't track with the javadoc for this class, which says "Slow/Large Log Query Filter with all filter and limit parameters". Also I think the comment should be updated to not mention the slow log too. Anyway, maybe a filter would want to filter more? Not a big deal, just wondering. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
