Apache9 commented on a change in pull request #4223:
URL: https://github.com/apache/hbase/pull/4223#discussion_r826576940
##########
File path: hbase-assembly/src/main/assembly/client.xml
##########
@@ -159,6 +160,8 @@
<include>io.opentelemetry.javaagent:*</include>
</includes>
</dependencySet>
+
Review comment:
Why these two blank lines?
##########
File path: hbase-assembly/src/main/assembly/hadoop-three-compat.xml
##########
@@ -261,6 +262,14 @@
<include>io.opentelemetry.javaagent:*</include>
</includes>
</dependencySet>
+
+ <!-- Adds junit libs to lib/test -->
+ <dependencySet>
+ <outputDirectory>lib/test</outputDirectory>
Review comment:
Will we load the libraries under this package?
And better also include hamcrest here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
