wchevreuil commented on a change in pull request #4223:
URL: https://github.com/apache/hbase/pull/4223#discussion_r827207342
##########
File path: hbase-assembly/src/main/assembly/hadoop-three-compat.xml
##########
@@ -261,6 +262,14 @@
<include>io.opentelemetry.javaagent:*</include>
</includes>
</dependencySet>
+
+ <!-- Adds junit libs to lib/test -->
+ <dependencySet>
+ <outputDirectory>lib/test</outputDirectory>
Review comment:
You mean add to hbase classpath by default? Junit used to be shipped
until it was scoped for test only on all modules, at least since release 2.4
(In 2.2 it was still shipped). In general, HBase processes seem to work pretty
fine without it on the CP. The only setback is for the test tooling, such as
`IntegrationTestIngest`, which will now fail without junit lib in the classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
