ndimiduk commented on pull request #4223: URL: https://github.com/apache/hbase/pull/4223#issuecomment-1069228770
I find all this very problematic. Our IntegrationTest classes are in a `/src/test/java` path, which maven associates with the `test-jar` artifact. I think what you need to do is include the test artifact as a dependency of the assembly plugin, so that all test-scope dependencies are included. However, as I pointed out in this comment on [#4016](https://github.com/apache/hbase/pull/4016#issuecomment-1048723158), maven doesn't pack transitive dependencies of test-jar artifacts. In general, it's an anti-pattern to have any dependency at all on test-jars. If we want to ship the IntegrationTest classes in our binary distribution, what we need to do is restructure hbase-it so that the IntegrationTest jars are in `src/main/java`. (We also need to mark them with some InterfaceAudience decoration, because they are in fact part of our public contract...) Restructuring the project like this will will have the happy benefit of allowing the maven assembly plugin to do the work for us. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
