ndimiduk commented on a change in pull request #4223:
URL: https://github.com/apache/hbase/pull/4223#discussion_r830979179
##########
File path: hbase-assembly/src/main/assembly/hadoop-three-compat.xml
##########
@@ -261,6 +262,14 @@
<include>io.opentelemetry.javaagent:*</include>
</includes>
</dependencySet>
+
+ <!-- Adds junit libs to lib/test -->
+ <dependencySet>
+ <outputDirectory>lib/test</outputDirectory>
Review comment:
For me, it is a security and release hygiene issue to ship test
dependencies in the runtime. It is problematic for me that some of our user
utilities have runtime dependency on test jars. Only mildly related: I'm
curious how much extra space those test dependencies consume in our release
artifacts.
Short of the restructuring that I suggested, I am okay with this approach of
isolating these test dependencies in their own directory and conditionally
including them at runtime. If there are classes that we know require them, our
`bin/hbase` script can intelligently add them to the classpath for those
classes. Doing so will preserve backward compatibility while also keeping the
extra jars out of the daemon services' classpaths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
