[
https://issues.apache.org/jira/browse/HBASE-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408344#comment-13408344
]
stack commented on HBASE-6337:
------------------------------
If you are removing tmp dir, don't be half-hearted about it. Go for it
Chunhui. So, for example here:
{code}
+ if (HLogSplitter.splitLogFileToTemp(rootdir, null,
{code}
... don't pass mull but remove the tmp arg. altogether (unless you have a
reason to retain it -- you seem to remove tmp dir elsewhere in your patch).
Is that all it takes?
Does this pass tests? What about the tests that replay recovered edits. These
are passing?
Good stuff Chunhui.
> [MTTR] Remove renaming tmp log file in SplitLogManager
> -------------------------------------------------------
>
> Key: HBASE-6337
> URL: https://issues.apache.org/jira/browse/HBASE-6337
> Project: HBase
> Issue Type: Bug
> Reporter: chunhui shen
> Assignee: chunhui shen
> Attachments: HBASE-6337v1.patch
>
>
> As HBASE-6309 mentioned, we also encounter problem of
> distributed-log-splitting take much more time than matser-local-log-splitting
> because lots of SplitLogManager 's renaming operations when finishing task.
> Could we try to remove renaming tmp log file in SplitLogManager through
> splitting log to regions' recover.edits directory directly as the same as the
> master-local-log-splitting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
