[
https://issues.apache.org/jira/browse/HBASE-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409164#comment-13409164
]
Zhihong Ted Yu commented on HBASE-6337:
---------------------------------------
For patch v2, I got a test failure:
{code}
testSplitLogFileFirstLineCorruptionLog(org.apache.hadoop.hbase.regionserver.wal.TestHLogSplit)
Time elapsed: 1.456 sec <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
at org.junit.Assert.fail(Assert.java:93)
at org.junit.Assert.failNotEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:128)
at org.junit.Assert.assertEquals(Assert.java:472)
at org.junit.Assert.assertEquals(Assert.java:456)
at
org.apache.hadoop.hbase.regionserver.wal.TestHLogSplit.testSplitLogFileFirstLineCorruptionLog(TestHLogSplit.java:1108)
{code}
See if you can reproduce it.
> [MTTR] Remove renaming tmp log file in SplitLogManager
> -------------------------------------------------------
>
> Key: HBASE-6337
> URL: https://issues.apache.org/jira/browse/HBASE-6337
> Project: HBase
> Issue Type: Bug
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6337v1.patch, HBASE-6337v2.patch
>
>
> As HBASE-6309 mentioned, we also encounter problem of
> distributed-log-splitting take much more time than matser-local-log-splitting
> because lots of SplitLogManager 's renaming operations when finishing task.
> Could we try to remove renaming tmp log file in SplitLogManager through
> splitting log to regions' recover.edits directory directly as the same as the
> master-local-log-splitting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira