[
https://issues.apache.org/jira/browse/HBASE-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409149#comment-13409149
]
chunhui shen commented on HBASE-6337:
-------------------------------------
@ted
With the patch, we will split log to region's directory directory like
master-local-log-splitting, so we needn't to call moveRecoveredEditsFromTemp
any more, the code
{code}
Path dst = ZKSplitLog.stripSplitLogTempDir(rootdir, src);
if (ZKSplitLog.isCorruptFlagFile(dst)) {
continue;
}
{code} is used to rename tmp log file, and we will judge whether the log file
is corrupted in new method
{code}
if (ZKSplitLog.isCorrupted(rootdir, logPath.getName(), fs)) {
+ corruptedLogs.add(logPath);
+ } else {
+ processedLogs.add(logPath);
+ }
{code}
@stack
HLogSplitter.splitLogFileToTemp will be called in many tests, in order to quick
solution, I just pass null rather than remove the tmp arg.
With the patch v2, I run the tests and passed in 0.94 version.
> [MTTR] Remove renaming tmp log file in SplitLogManager
> -------------------------------------------------------
>
> Key: HBASE-6337
> URL: https://issues.apache.org/jira/browse/HBASE-6337
> Project: HBase
> Issue Type: Bug
> Reporter: chunhui shen
> Assignee: chunhui shen
> Attachments: HBASE-6337v1.patch
>
>
> As HBASE-6309 mentioned, we also encounter problem of
> distributed-log-splitting take much more time than matser-local-log-splitting
> because lots of SplitLogManager 's renaming operations when finishing task.
> Could we try to remove renaming tmp log file in SplitLogManager through
> splitting log to regions' recover.edits directory directly as the same as the
> master-local-log-splitting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
