NihalJain commented on PR #5623: URL: https://github.com/apache/hbase/pull/5623#issuecomment-1890565147
I am fine with ```<scope>runtime</scope>`` as this makes more sense and yes it is better for the jar to be packaged to avoid having to track the appropriate thirdparty version for a hbase build. But I have a doubt after going through the release note of HBASE-28008 (which I assume is the JIRA which needs this dependendency). The RN says: > If a properly shaded netty-tcnative is found on the classpath, hbase will automatically pick it up for use in accelerating TLS handling. Properly shaded means relocated to prefix with org.apache.hbase.thirdparty Also looked at https://github.com/apache/hbase/pull/5363/files, where I see if jar is on classpath and in case config TLS_USE_OPENSSL is not set/over riden, it will be enabled by default. If we plan on packaging this we are actually enabling this feature without user knowing it. Should we not change the default value to false to aoid this? Please let me know if I understood correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
