bbeaudreault commented on PR #5623:
URL: https://github.com/apache/hbase/pull/5623#issuecomment-1890753595
I just pushed a new commit which introduces the following hierarchy:
```
hbase
-\ hbase-assembly
-\ hbase-client
-\ etc...
-\ hbase-extensions
-\ hbase-openssl
```
`hbase-openssl` includes runtime dependency on hbase-shaded-netty-tcnative.
`hbase-assembly` has been updated to depend on `hbase-openssl` instead. I've
verified that the binaries still include the right jar:
```
❯ tar -ztvf
hbase-assembly/target/hbase-4.0.0-alpha-1-SNAPSHOT-client-bin.tar.gz | grep
tcnative
-rw-r--r-- 0 root root 5437808 Jan 22 2020
hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-shaded-netty-tcnative-4.1.5.jar
❯ tar -ztvf hbase-assembly/target/hbase-4.0.0-alpha-1-SNAPSHOT-bin.tar.gz |
grep tcnative
-rw-r--r-- 0 root root 5437808 Jan 22 2020
hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-shaded-netty-tcnative-4.1.5.jar
```
I've also tested this in a downstream project to verify that the tcnative
classes/libs get added to my fat jar if i include hbase-openssl dependency in
my downstream project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
