bbeaudreault commented on PR #5623: URL: https://github.com/apache/hbase/pull/5623#issuecomment-1890589430
You understand correctly. We could definitely change the default value. However since this TLS support is as-yet unreleased, we have freedom to decide the default behavior for the first release. (2.6.0) I don't have a super strong opinion, would be happy to default to no OpenSSL if desired. But I can't think of a reason not to use OpenSSL if available, except maybe if you don't want to use direct memory. One reason not to include tcnative as a dependency by default is that most users probably won't be using TLS for the near future. Another option I thought of is to create a new core module `hbase-extensions` (or something). It could have a sub module `hbase-openssl-support` which lists tcnative as a dependency. The benefit of this is someone can decide to add a dependency on this module or not, and if they do it will pull in the right hbase-thirdpary release without having to explicitly define it. That's the big win I'm trying to get by defining it at all. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
