gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1571011511
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java:
##########
@@ -666,8 +666,9 @@ private Pair<List<Path>, List<Path>> splitStoreFiles(final
MasterProcedureEnv en
// table dir. In case of failure, the proc would go through this again,
already existing
// region dirs and split files would just be ignored, new split files
should get created.
int nbFiles = 0;
- final Map<String, Collection<StoreFileInfo>> files =
- new HashMap<String,
Collection<StoreFileInfo>>(htd.getColumnFamilyCount());
+ final Map<String, Pair<Collection<StoreFileInfo>, StoreFileTracker>> files
=
Review Comment:
No we have a StoreFileTracker per column family, we refactored current
struct which contains [columnFamilyName] ---> [ Collection(StoreFileInfo)
] to
[columnFamilyName] ---> [ Collection(StoreFileInfo) + sft ]
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java:
##########
@@ -666,8 +666,9 @@ private Pair<List<Path>, List<Path>> splitStoreFiles(final
MasterProcedureEnv en
// table dir. In case of failure, the proc would go through this again,
already existing
// region dirs and split files would just be ignored, new split files
should get created.
int nbFiles = 0;
- final Map<String, Collection<StoreFileInfo>> files =
- new HashMap<String,
Collection<StoreFileInfo>>(htd.getColumnFamilyCount());
+ final Map<String, Pair<Collection<StoreFileInfo>, StoreFileTracker>> files
=
Review Comment:
No we have a StoreFileTracker per column family here, we refactored current
struct which contains [columnFamilyName] ---> [ Collection(StoreFileInfo)
] to
[columnFamilyName] ---> [ Collection(StoreFileInfo) + sft ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
