gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1571045154
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java:
##########
@@ -822,22 +825,25 @@ private class StoreFileSplitter implements
Callable<Pair<Path, Path>> {
private final HRegionFileSystem regionFs;
private final byte[] family;
private final HStoreFile sf;
+ private final StoreFileTracker tracker;
/**
* Constructor that takes what it needs to split
* @param regionFs the file system
* @param family Family that contains the store file
* @param sf which file
*/
- public StoreFileSplitter(HRegionFileSystem regionFs, byte[] family,
HStoreFile sf) {
+ public StoreFileSplitter(HRegionFileSystem regionFs, StoreFileTracker
tracker, byte[] family,
+ HStoreFile sf) {
this.regionFs = regionFs;
this.sf = sf;
this.family = family;
+ this.tracker = tracker;
}
@Override
public Pair<Path, Path> call() throws IOException {
- return splitStoreFile(regionFs, family, sf);
+ return splitStoreFile(regionFs, tracker, family, sf);
Review Comment:
Yes if we can add this api as well in SFT, it will be easier to choose if
where we want multi threading, but both impls might still need multi threading
while initiating reader for all the parent store files while reading metadata
for first/lastkeys.
But yes, we can get to it in detail as part of our last phase of
[implementation](https://docs.google.com/document/d/18aHEv7w0RExV6nJbJaVnTR6NIqbiWHIVUvU7v9rvXAk/edit#heading=h.4tx7yijt3qa1)
may be, where we want to commit all the ref/links in 1 go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
