gvprathyusha6 commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2064857989
> Checked the POC, overall good. > > It is a pain that we need to touch the MOB related code. > > Anyway, I think first we could first do some refactorings, to move the reference file related logic to StoreFileTracker, without changing any real logic. And then, another refactoring to move HFileLink, and back reference files related logic to StoreFileTracker. And finally, we start to change the implementation of StoreFileTracker, to implement the special logic for FileBasedStoreFileTracker, and also consider how to migrate between different store file tracker implementions. > > WDYT? > > Thanks. > Checked the POC, overall good. > > It is a pain that we need to touch the MOB related code. > > Anyway, I think first we could first do some refactorings, to move the reference file related logic to StoreFileTracker, without changing any real logic. And then, another refactoring to move HFileLink, and back reference files related logic to StoreFileTracker. And finally, we start to change the implementation of StoreFileTracker, to implement the special logic for FileBasedStoreFileTracker, and also consider how to migrate between different store file tracker implementions. > > WDYT? > > Thanks. Totally agree, we can target them 1 pr at a time. - to move the reference file related logic to StoreFileTracker - then, another refactoring to move HFileLink, and back reference files - then we start to change the implementation of StoreFileTracker, to implement the special logic for FileBasedStoreFileTracker to create virtual links - and commit all the ref files as part of split in 1 go Thanks a lot for the review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
