hgromer commented on code in PR #7294:
URL: https://github.com/apache/hbase/pull/7294#discussion_r2349897007
##########
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestWALPlayer.java:
##########
@@ -335,7 +351,29 @@ public void testMainMethod() throws Exception {
System.setErr(oldPrintStream);
System.setSecurityManager(SECURITY_MANAGER);
}
+ }
+
+ private static void runWithDiskBasedSortingDisabledAndEnabled(TestMethod
method)
Review Comment:
Let me know if you disagree with this testing strategy, but I felt that the
existing tests were comprehensive and this was a good way of running with both
versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
