hgromer commented on code in PR #7294:
URL: https://github.com/apache/hbase/pull/7294#discussion_r2352319579
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalTableBackupClient.java:
##########
@@ -421,13 +429,16 @@ protected void walToHFiles(List<String> dirPaths,
List<String> tableList) throws
if (result != 0) {
throw new IOException("WAL Player failed");
}
- conf.unset(WALPlayer.INPUT_FILES_SEPARATOR_KEY);
- conf.unset(JOB_NAME_CONF_KEY);
} catch (IOException e) {
throw e;
} catch (Exception ee) {
throw new IOException("Can not convert from directory " + dirs
+ " (check Hadoop, HBase and WALPlayer M/R job logs) ", ee);
+ } finally {
+ conf.setBoolean(HFileOutputFormat2.DISK_BASED_SORTING_ENABLED_KEY,
+ diskBasedSortingEnabledOriginalValue);
+ conf.unset(WALPlayer.INPUT_FILES_SEPARATOR_KEY);
Review Comment:
Moving all of these into the `finally` block, otherwise we may not unset them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
