DieterDP-ng commented on code in PR #7294:
URL: https://github.com/apache/hbase/pull/7294#discussion_r2351557063
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalTableBackupClient.java:
##########
@@ -421,6 +425,7 @@ protected void walToHFiles(List<String> dirPaths,
List<String> tableList) throws
if (result != 0) {
throw new IOException("WAL Player failed");
}
+ conf.unset(HFileOutputFormat2.DISK_BASED_SORTING_ENABLED_KEY);
Review Comment:
Shouldn't we check and re-set the original value, rather than just unsetting
here?
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalTableBackupClient.java:
##########
@@ -360,6 +362,7 @@ protected void incrementalCopyHFiles(String[] files, String
backupDest) throws I
+ " finished.");
} finally {
deleteBulkLoadDirectory();
+ conf.unset(HFileOutputFormat2.DISK_BASED_SORTING_ENABLED_KEY);
Review Comment:
Shouldn't we check and re-set the original value, rather than just unsetting
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
