charlesconnell commented on code in PR #7418:
URL: https://github.com/apache/hbase/pull/7418#discussion_r2466852703
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java:
##########
@@ -349,12 +348,7 @@ public ByteBuff allocate(int size) {
* Free all direct buffers if allocated, mainly used for testing.
*/
public void clean() {
- while (!buffers.isEmpty()) {
- ByteBuffer b = buffers.poll();
- if (b.isDirect()) {
- UnsafeAccess.freeDirectBuffer(b);
- }
- }
Review Comment:
This was only used in testing, and I think it'll be okay to just let the GC
free the buffers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
