charlesconnell commented on code in PR #7418:
URL: https://github.com/apache/hbase/pull/7418#discussion_r2466865060
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java:
##########
@@ -58,28 +73,6 @@ static abstract class Comparer {
abstract int compareTo(ByteBuffer buf1, int o1, int l1, ByteBuffer buf2,
int o2, int l2);
}
- static abstract class Converter {
Review Comment:
I don't think we'll do better than VarHandle, mulitple Converting
implementations are not needed. I'm simplifying ByteBufferUtils by removing the
Converter interface, and putting the implementations directly in the
ByteBufferUtils methods where needed.
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java:
##########
@@ -58,28 +73,6 @@ static abstract class Comparer {
abstract int compareTo(ByteBuffer buf1, int o1, int l1, ByteBuffer buf2,
int o2, int l2);
}
- static abstract class Converter {
Review Comment:
I don't think we'll do better than VarHandle, mulitple Converter
implementations are not needed. I'm simplifying ByteBufferUtils by removing the
Converter interface, and putting the implementations directly in the
ByteBufferUtils methods where needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
