charlesconnell commented on code in PR #7418:
URL: https://github.com/apache/hbase/pull/7418#discussion_r2466870965
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java:
##########
@@ -88,349 +81,150 @@ abstract int findCommonPrefix(ByteBuffer left, int
leftOffset, int leftLength, B
int rightOffset, int rightLength);
}
+ /**
+ * <a href=
+ *
"https://github.com/google/guava/blob/v21.0/guava/src/com/google/common/primitives/UnsignedBytes.java#L362";>Adapted
+ * from Guava</a>
+ */
static class ComparerHolder {
- static final String UNSAFE_COMPARER_NAME = ComparerHolder.class.getName()
+ "$UnsafeComparer";
-
static final Comparer BEST_COMPARER = getBestComparer();
static Comparer getBestComparer() {
Review Comment:
I am keeping the Comparer interface, because when the Vector API (hopefully)
gets standardized, we can try to load a Vector-based comparer at runtime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
