taklwu commented on code in PR #7577:
URL: https://github.com/apache/hbase/pull/7577#discussion_r2651760363
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java:
##########
@@ -204,8 +202,6 @@ public void init(Configuration conf, FileSystem fs,
ReplicationSourceManager man
this.waitOnEndpointSeconds =
this.conf.getInt(WAIT_ON_ENDPOINT_SECONDS,
DEFAULT_WAIT_ON_ENDPOINT_SECONDS);
decorateConf();
- // 1 second
- this.sleepForRetries =
this.conf.getLong("replication.source.sleepforretries", 1000);
Review Comment:
nit: do you think this `sleepForRetries` would be changing dynamically after
the initialization ? IIRC it would be only reloading via `refreshSources` (e.g.
via `updateReplicationPeerConfig` ) such that this value would only created
once per peer configuration or refresh.
so, can we keep this variable and just call `getSleepForRetries()` once
within `ReplicationSource.java`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
