taklwu commented on code in PR #7577:
URL: https://github.com/apache/hbase/pull/7577#discussion_r2653578912
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java:
##########
@@ -862,4 +862,14 @@ public String logPeerId() {
public long getTotalReplicatedEdits() {
return totalReplicatedEdits.get();
}
+
+ @Override
+ public long getSleepForRetriesForTesting() {
+ return sleepForRetries;
+ }
+
+ @Override
+ public Map<String, ReplicationSourceShipper> getWorkerThreadsForTesting() {
+ return workerThreads;
+ }
}
Review Comment:
nit: I don't know if we should have the `*ForTesting` in any interface in
the scope of the IA.Private, but at least to align with other lines, we can
keep the `getSleepForRetries` (no `ForTesting`) and only have the
`getWorkerThreadsForTesting` in the `ReplicationSource`.
```suggestion
@Override
public long getSleepForRetries() {
return sleepForRetries;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
