sidkhillon commented on code in PR #7577:
URL: https://github.com/apache/hbase/pull/7577#discussion_r2653598626


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java:
##########
@@ -862,4 +862,14 @@ public String logPeerId() {
   public long getTotalReplicatedEdits() {
     return totalReplicatedEdits.get();
   }
+
+  @Override
+  public long getSleepForRetriesForTesting() {
+    return sleepForRetries;
+  }
+
+  @Override
+  public Map<String, ReplicationSourceShipper> getWorkerThreadsForTesting() {
+    return workerThreads;
+  }
 }

Review Comment:
   To clarify why I added it to the interface: most of the methods return 
ReplicationSourceInterface and therefore to use those methods in the test I'd 
need to either cast to the specific implementation of ReplicationSource or add 
the methods to the interface. I went for the latter option, but I could change 
it to the former if you'd prefer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to