taklwu commented on code in PR #7577:
URL: https://github.com/apache/hbase/pull/7577#discussion_r2653816723
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/PeerProcedureHandlerImpl.java:
##########
@@ -108,6 +109,33 @@ public void disablePeer(String peerId) throws
ReplicationException, IOException
refreshPeerState(peerId);
}
+ private boolean hasReplicationConfigChange(ReplicationPeerConfig oldConfig,
+ ReplicationPeerConfig newConfig) {
+ Map<String, String> oldReplicationConfigs = oldConfig.getConfiguration();
+ Map<String, String> newReplicationConfigs = newConfig.getConfiguration();
+
+ // Check if any replication.source.* keys have changed values
+ for (Map.Entry<String, String> entry : newReplicationConfigs.entrySet()) {
+ String key = entry.getKey();
+ if (key.startsWith("replication.source.")) {
Review Comment:
do we need to handle the following keys? if not, then your change looks good
to me
hbase.replication.source.fs.conf.provider
hbase.replication.source.service
hbase.replication.source.maxthreads
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
