wchevreuil commented on code in PR #8353:
URL: https://github.com/apache/hbase/pull/8353#discussion_r3419675270
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##########
@@ -1336,9 +1346,8 @@ public HFileBlock readBlock(long dataBlockOffset, long
onDiskBlockSize, final bo
// the other choice is to duplicate work (which the cache would prevent you
// from doing).
- BlockCacheKey cacheKey =
- new BlockCacheKey(path, dataBlockOffset, this.isPrimaryReplicaReader(),
expectedBlockType);
-
+ BlockCacheKey cacheKey = new BlockCacheKey(path.getName(), family, region,
dataBlockOffset,
Review Comment:
The culprits, as seem by the async profiler flamegraphs, are
Path.getParent() and HFileArchiveUtil.isFileArchived(). I didn't think of doing
the same for the file name because that didn't seem to cause problems, but
yeah, could do it for the sake of code consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
