Apache9 commented on code in PR #8353:
URL: https://github.com/apache/hbase/pull/8353#discussion_r3421186293
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheKey.java:
##########
@@ -115,7 +114,7 @@ public BlockCacheKey(String hfileName, String cfName,
String regionName, long of
public BlockCacheKey(Path hfilePath, long offset, boolean isPrimaryReplica,
BlockType blockType) {
this(hfilePath.getName(), hfilePath.getParent().getName(),
hfilePath.getParent().getParent().getName(), offset, isPrimaryReplica,
blockType,
- HFileArchiveUtil.isHFileArchived(hfilePath));
Review Comment:
Then can we just remove this constructor? Or leave the code as is since it
only calls from test code? It does not affect real performance if it only calls
in test code right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
