kgeisz commented on code in PR #8676:
URL: https://github.com/apache/hbase/pull/8676#discussion_r4041719708
##########
dev-support/read-replica/.env:
##########
@@ -22,7 +22,7 @@ HBASE_CONTAINER_NAME=hbase-docker
# This is the host running the hbase-docker containers. Use localhost if the
containers
# are running locally. If they are started by another container, such as a
Jenkins
# container in a Docker-out-of-Docker setup, then try setting this to
host.docker.internal.
-HBASE_HOST=${HBASE_HOST:-localhost}
+HBASE_HOST=${HBASE_HOST:-host.docker.internal}
Review Comment:
@taklwu this needs to be set to `host.docker.internal` in order to get it
running in my local Jenkins setup. We will see how this goes with the upstream
Jenkins.
`HBASE_HOST` is used for curling the HBase UI to see if it's up. It's part
of the process of verifying HBase has started. ([here it is in the
code](https://github.com/kgeisz/hbase/blob/HBASE-30087-read-replica-jenkinsfile-test/dev-support/read-replica/python/src/hbase_docker_client.py#L146))
The only problem with this is if I want to run the tests locally with
`hbase_nightly_read_replica_test.sh` (without Jenkins) then `HBASE_HOST` should
be `localhost`. We may want to think of a way to make it easier for a user to
run this without having to know they should modify `HBASE_HOST` to make it
`localhost`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
