Copilot commented on code in PR #8676:
URL: https://github.com/apache/hbase/pull/8676#discussion_r4048829209
##########
dev-support/read-replica/.env:
##########
@@ -22,7 +22,7 @@ HBASE_CONTAINER_NAME=hbase-docker
# This is the host running the hbase-docker containers. Use localhost if the
containers
# are running locally. If they are started by another container, such as a
Jenkins
# container in a Docker-out-of-Docker setup, then try setting this to
host.docker.internal.
-HBASE_HOST=${HBASE_HOST:-localhost}
+HBASE_HOST=${HBASE_HOST:-host.docker.internal}
Review Comment:
This default contradicts the preceding guidance and breaks the documented
host-native invocation on Linux: pytest runs on the caller and connects to the
published ports via `HBASE_HOST`, while `extra_hosts` only defines
`host.docker.internal` inside the HBase containers. Keep `localhost` as the
local default and set `HBASE_HOST=host.docker.internal` explicitly for the
Docker-out-of-Docker Jenkins environment.
##########
dev-support/read-replica/Jenkinsfile:
##########
@@ -0,0 +1,144 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+pipeline {
+ agent any
Review Comment:
The extracted test now runs on any Jenkins node, whereas the removed stage
and the surrounding HBase pipelines require the `hbase` label. This driver
invokes Docker, Maven, Python, and related host tooling, so an unrestricted
executor can be selected without those prerequisites and fail before the tests
run. Preserve the prior node constraint.
##########
dev-support/read-replica/Jenkinsfile:
##########
@@ -0,0 +1,144 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+pipeline {
+ agent any
+ options {
+ buildDiscarder(logRotator(numToKeepStr: '10'))
+ timeout (time: 2, unit: 'HOURS')
+ timestamps()
+ skipDefaultCheckout()
+ disableConcurrentBuilds()
+ }
+ environment {
+ OUTPUT_DIR_RELATIVE_READ_REPLICA = 'output-read-replica'
+ }
+ stages {
Review Comment:
This standalone pipeline has no `triggers` block, so it no longer inherits
the main Jenkinsfile's `pollSCM(getCronParams(...))` schedule. Unless an
external job configuration supplies a trigger, the documented nightly pipeline
will never start on its own; preserve the schedule here or include the
corresponding Jenkins job configuration in the rollout.
##########
dev-support/read-replica/Jenkinsfile:
##########
@@ -0,0 +1,144 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+pipeline {
+ agent any
+ options {
+ buildDiscarder(logRotator(numToKeepStr: '10'))
+ timeout (time: 2, unit: 'HOURS')
+ timestamps()
+ skipDefaultCheckout()
+ disableConcurrentBuilds()
+ }
+ environment {
+ OUTPUT_DIR_RELATIVE_READ_REPLICA = 'output-read-replica'
+ }
+ stages {
+ stage ('scm-checkout') {
+ steps {
+ dir('component') {
+ checkout scm
+ }
+ }
+ }
+ stage ('init health results') {
+ steps {
+ stash name: 'read-replica-result', allowEmpty: true, includes:
"${OUTPUT_DIR_RELATIVE_READ_REPLICA}/doesn't-match"
+ }
+ }
+ stage ('hbase read-replica feature checks') {
Review Comment:
The removed stage was guarded to run only on `master` and `branch-3`, but
the extracted stage has no `when` condition even though the updated README
still promises that restriction. In a multibranch job this allows expensive
Docker integration tests on every indexed branch; retain the original branch
guard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
