kgeisz commented on code in PR #8676:
URL: https://github.com/apache/hbase/pull/8676#discussion_r4076924173
##########
dev-support/read-replica/python/src/hbase_docker_client.py:
##########
@@ -141,26 +136,27 @@ def _get_pid_from_jps(self, process_name: str) -> int |
None:
return None
def wait_for_hbase_ui(self) -> bool:
- """Checks for a 200 OK on the HBase Master UI."""
- # Read HBASE_HOST from environment, falling back to 'localhost' for
host-native execution
- url = f"http://{self._hbase_host}:{self._hbase_ui_port}";
- logger.info(f"Waiting for HBase UI: {self._cluster_name} on {url}")
- last_exception = None
+ """
+ Checks for a 200 OK on the HBase Master UI inside the container using
curl.
+ """
+ check_cmd = f"curl -s -f --max-time 3
http://{self._container_name}:{self._hbase_ui_port} > /dev/null"
Review Comment:
@taklwu, IMO this can be ignored. `curl` is a dependency of the `rpm`
package, which will always be included in the image.
From inside the Docker container:
```
$ rpm -q --whatrequires curl
rpm-4.14.3-32.el8_10.aarch64
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
