kgeisz commented on PR #8845:
URL: https://github.com/apache/hbase/pull/8845#issuecomment-6982700043
Hi @taklwu, I make some changes based on your review. The changes are in a
new commit. I can squash it when everything looks good
- Added `deleteBackupCompleteMarker()` method to `HBackupFileSystem.java`
- Added unit tests for this new method
- Also now catching `RuntimeException` in `writeBackupCompleteMarker()`
- `repairFailedBackupMergeIfAny()` now tries to write the marker file after
a merge repair
- Also deletes the marker file for removed backup images
- Delete marker file first in `TableBackupClient.cleanupTargetDir()`
- Write marker file last in `TableBackupClient.completeBackup()`
- Write marker file last in `MapReduceBackupMergeJob.run()`
- Also delete marker file first for each backup in
`MapReduceBackupMergeJob.deleteBackupImages()`
- Delete backup marker first in `BackupUtils.cleanupTargetDir()`
- Add marker file existence/non-existence assertions to unit tests
- Update `TestIncrementalBackupMergeWithFailures.run()` to be consistent
with `MapReduceBackupMergeJob.run()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]