VladRodionov commented on PR #8845:
URL: https://github.com/apache/hbase/pull/8845#issuecomment-6992058136

   According to GTP-6 Astra there are still potential correctness issues. 
@kgeisz please verify that they are real issues and address them. Overall it is 
pretty close to completion.
   
   Request changes. I found three correctness issues in head df96268627ed.
   1. [P1] Write the marker before releasing the backup lock.
      finishBackupSession() releases the exclusive lock before marker creation. 
A concurrent delete can remove the backup, after which the delayed marker write 
recreates its directory containing only .backup.complete. A concurrent merge 
can similarly receive a premature marker. The same ordering appears in merge 
completion and repair. Keep marker publication inside the exclusive operation. 
[TableBackupClient.java:416–418](https://github.com/apache/hbase/pull/8845/files)
   2. [P2] Stop failed-backup cleanup if marker removal fails.
      The new catch logs the failure and continues deleting table data. When 
repairing a backup with a stale marker—the scenario the added repair test 
covers—a marker-specific deletion failure therefore leaves .backup.complete 
pointing to an image whose data has been removed. Abort cleanup and propagate 
the failure so repair can retry. 
[TableBackupClient.java:195–200](https://github.com/apache/hbase/pull/8845/files)
   3. [P2] Propagate marker-removal errors through normal backup deletion.
      Here, marker deletion failure stops filesystem cleanup, but the method’s 
existing outer catch swallows the exception. BackupAdminImpl.deleteBackup() 
consequently continues, removes the system-table record, and counts the backup 
as deleted while its data and marker remain. Subsequent deletion by ID cannot 
find it. Propagate the error before deleting metadata. 
[BackupUtils.java:541–544](https://github.com/apache/hbase/pull/8845/files) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to