kgeisz commented on PR #8845: URL: https://github.com/apache/hbase/pull/8845#issuecomment-6995479185
I have addressed @VladRodionov's feedback. I'm hoping everything is good to go now. I decided to go back to writing the marker file before releasing the backup lock. This goes against @taklwu's original suggestion. My reasoning is if `finishBackupSession()` fails, `failBackup` removes the marker before touching data. This means a consumer sees at most a short-lived marker, the same as racing a normal delete. However, writing after the lock is released can leave a marker that stays wrong (a marker-only dir after a concurrent delete or merge), which is worse. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
