[ 
https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538121#comment-13538121
 ] 

Matteo Bertozzi commented on HBASE-7294:
----------------------------------------

this was written on top of the online branch. to avoid move around the code 
from HMaster to SnapshotManager
                
> Check for snapshot file cleaners on start
> -----------------------------------------
>
>                 Key: HBASE-7294
>                 URL: https://issues.apache.org/jira/browse/HBASE-7294
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, master, regionserver, snapshots, Zookeeper
>    Affects Versions: hbase-6055
>            Reporter: Jesse Yates
>            Assignee: Matteo Bertozzi
>             Fix For: hbase-6055, 0.96.0
>
>         Attachments: HBASE-7294-v1.patch, HBASE-7294-v2.patch, 
> HBASE-7294-v3.patch, HBASE-7294-v4.patch
>
>
> Snapshots currently use the SnaphotHfileCleaner and SnapshotHLogCleaner to 
> ensure that any hfiles or hlogs (respectively) that are currently part of a 
> snapshot are not removed from their respective archive directories (.archive 
> and .oldlogs).
> From Matteo Bertozzi:
> {quote}
> currently the snapshot cleaner is not in hbase-default.xml
> and there's no warning/exception on snapshot/restore operation, if not 
> enabled.
> even if we add the cleaner to the hbase-default.xml how do we ensure that the 
> user doesn't remove it?
> Do we want to hardcode the cleaner at master startup?
> Do we want to add a check in snapshot/restore that throws an exception if the 
> cleaner is not enabled?
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to