[
https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540393#comment-13540393
]
Jonathan Hsieh commented on HBASE-7294:
---------------------------------------
Came back with some consistent failures. The first two are likely related to
this patch, the latter was an error present previously and on trunk (so
ignoring it for this patch for now)
{code}
...
17:09:14 Running org.apache.hadoop.hbase.TestInfoServers
17:09:14 Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
15.757 sec <<< FAILURE!
...
17:12:05 Running org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster
17:12:05 Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
35.534 sec <<< FAILURE!
...
17:19:07 Running org.apache.hadoop.hbase.client.TestHCM
17:19:07 Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
76.637 sec <<< FAILURE!
{code}
> Check for snapshot file cleaners on start
> -----------------------------------------
>
> Key: HBASE-7294
> URL: https://issues.apache.org/jira/browse/HBASE-7294
> Project: HBase
> Issue Type: Sub-task
> Components: Client, master, regionserver, snapshots, Zookeeper
> Affects Versions: hbase-6055
> Reporter: Jesse Yates
> Assignee: Matteo Bertozzi
> Fix For: hbase-6055, 0.96.0
>
> Attachments: HBASE-7294-v1.patch, HBASE-7294-v2.patch,
> HBASE-7294-v3.patch, HBASE-7294-v4.patch, HBASE-7294-v5.patch,
> HBASE-7294-v6.patch
>
>
> Snapshots currently use the SnaphotHfileCleaner and SnapshotHLogCleaner to
> ensure that any hfiles or hlogs (respectively) that are currently part of a
> snapshot are not removed from their respective archive directories (.archive
> and .oldlogs).
> From Matteo Bertozzi:
> {quote}
> currently the snapshot cleaner is not in hbase-default.xml
> and there's no warning/exception on snapshot/restore operation, if not
> enabled.
> even if we add the cleaner to the hbase-default.xml how do we ensure that the
> user doesn't remove it?
> Do we want to hardcode the cleaner at master startup?
> Do we want to add a check in snapshot/restore that throws an exception if the
> cleaner is not enabled?
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
