[ 
https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538233#comment-13538233
 ] 

Jonathan Hsieh commented on HBASE-7294:
---------------------------------------

Ok, this make this hard to commit.  I'll add it to my working branch but not 
close this until we get the patches it depends upon committed to the online 
branch.

[~jesse_yates] -- we were in a similar position we were at with the offline 
stuff before -- we can't commit this because it depends on work that hasn't 
been committed to a common branch yet, and preventing other folks from working 
on this.  Can you do a pass and consider +1'ing some things with caveats to 
follow-up on?  (HBASE-7208, HBASE-7212, HBASE-6864, HBASE-7321).






                
> Check for snapshot file cleaners on start
> -----------------------------------------
>
>                 Key: HBASE-7294
>                 URL: https://issues.apache.org/jira/browse/HBASE-7294
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, master, regionserver, snapshots, Zookeeper
>    Affects Versions: hbase-6055
>            Reporter: Jesse Yates
>            Assignee: Matteo Bertozzi
>             Fix For: hbase-6055, 0.96.0
>
>         Attachments: HBASE-7294-v1.patch, HBASE-7294-v2.patch, 
> HBASE-7294-v3.patch, HBASE-7294-v4.patch
>
>
> Snapshots currently use the SnaphotHfileCleaner and SnapshotHLogCleaner to 
> ensure that any hfiles or hlogs (respectively) that are currently part of a 
> snapshot are not removed from their respective archive directories (.archive 
> and .oldlogs).
> From Matteo Bertozzi:
> {quote}
> currently the snapshot cleaner is not in hbase-default.xml
> and there's no warning/exception on snapshot/restore operation, if not 
> enabled.
> even if we add the cleaner to the hbase-default.xml how do we ensure that the 
> user doesn't remove it?
> Do we want to hardcode the cleaner at master startup?
> Do we want to add a check in snapshot/restore that throws an exception if the 
> cleaner is not enabled?
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to