[
https://issues.apache.org/jira/browse/HIVE-26771?focusedWorklogId=829964&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-829964
]
ASF GitHub Bot logged work on HIVE-26771:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/22 07:44
Start Date: 30/Nov/22 07:44
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3802:
URL: https://github.com/apache/hive/pull/3802#discussion_r1035625885
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -236,11 +236,25 @@ public void
commitCreateTable(org.apache.hadoop.hive.metastore.api.Table hmsTabl
setFileFormat(catalogProperties.getProperty(TableProperties.DEFAULT_FILE_FORMAT));
String metadataLocation =
hmsTable.getParameters().get(BaseMetastoreTableOperations.METADATA_LOCATION_PROP);
+ Table table;
if (metadataLocation != null) {
- Catalogs.registerTable(conf, catalogProperties, metadataLocation);
+ table = Catalogs.registerTable(conf, catalogProperties,
metadataLocation);
} else {
- Catalogs.createTable(conf, catalogProperties);
+ table = Catalogs.createTable(conf, catalogProperties);
}
+
+ if
(!Boolean.parseBoolean(catalogProperties.getProperty(hive_metastoreConstants.TABLE_IS_CTAS)))
{
Review Comment:
can we extract this in a helper method `isCtas(catalogProperties)`?
Issue Time Tracking
-------------------
Worklog Id: (was: 829964)
Time Spent: 1h (was: 50m)
> Use DDLTask to created Iceberg table when running ctas statement
> ----------------------------------------------------------------
>
> Key: HIVE-26771
> URL: https://issues.apache.org/jira/browse/HIVE-26771
> Project: Hive
> Issue Type: Improvement
> Components: Iceberg integration
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When Iceberg table is created via ctas statement the table is created in
> HiveIcebergSerDe and no DDL task is executed.
> Negative effects of this workflow:
> * Missing table properties: format-version, write.[delete|update|merge].mode
> * Default privileges of the new table are not granted.
> * The new Iceberg table can be seen by other transactions at compile time of
> ctas.
> * Table creation and table properties are not shown in explain ctas output.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
