[
https://issues.apache.org/jira/browse/HIVE-26771?focusedWorklogId=830048&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-830048
]
ASF GitHub Bot logged work on HIVE-26771:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/22 12:59
Start Date: 30/Nov/22 12:59
Worklog Time Spent: 10m
Work Description: kasakrisz commented on code in PR #3802:
URL: https://github.com/apache/hive/pull/3802#discussion_r1035938726
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -828,16 +836,19 @@ static void overlayTableProperties(Configuration
configuration, TableDesc tableD
map.put(InputFormatConfig.SERIALIZED_TABLE_PREFIX +
tableDesc.getTableName(),
SerializationUtil.serializeToBase64(serializableTable));
} catch (NoSuchTableException ex) {
- if
(!(StringUtils.isNotBlank(props.getProperty(hive_metastoreConstants.TABLE_IS_CTAS))
&&
-
StringUtils.isNotBlank(props.getProperty(Constants.EXPLAIN_CTAS_LOCATION)))) {
+ if
(!StringUtils.isNotBlank(props.getProperty(hive_metastoreConstants.TABLE_IS_CTAS)))
{
Review Comment:
done
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java:
##########
@@ -303,6 +303,22 @@ public void compile(final ParseContext pCtx,
setInputFormat(rootTask);
}
+ if (directInsert) {
+ Task<?> crtTask = null;
+ if (pCtx.getCreateTable() != null) {
+ CreateTableDesc crtTblDesc = pCtx.getCreateTable();
+ crtTblDesc.validate(conf);
+ crtTask = TaskFactory.get(new DDLWork(inputs, outputs, crtTblDesc));
Review Comment:
removed
Issue Time Tracking
-------------------
Worklog Id: (was: 830048)
Time Spent: 2h 20m (was: 2h 10m)
> Use DDLTask to created Iceberg table when running ctas statement
> ----------------------------------------------------------------
>
> Key: HIVE-26771
> URL: https://issues.apache.org/jira/browse/HIVE-26771
> Project: Hive
> Issue Type: Improvement
> Components: Iceberg integration
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> When Iceberg table is created via ctas statement the table is created in
> HiveIcebergSerDe and no DDL task is executed.
> Negative effects of this workflow:
> * Missing table properties: format-version, write.[delete|update|merge].mode
> * Default privileges of the new table are not granted.
> * The new Iceberg table can be seen by other transactions at compile time of
> ctas.
> * Table creation and table properties are not shown in explain ctas output.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
