[jira] [Work logged] (HIVE-26771) Use DDLTask to created Iceberg table when running ctas statement

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/HIVE-26771?focusedWorklogId=829972&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-829972
 ]

ASF GitHub Bot logged work on HIVE-26771:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Nov/22 08:10
            Start Date: 30/Nov/22 08:10
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #3802:
URL: https://github.com/apache/hive/pull/3802#discussion_r1035647451


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -462,7 +461,11 @@ public boolean commitInMoveTask() {
   @Override
   public void storageHandlerCommit(Properties commitProperties, boolean 
overwrite) throws HiveException {
     String tableName = commitProperties.getProperty(Catalogs.NAME);
+    String location = commitProperties.getProperty(Catalogs.LOCATION);
     Configuration configuration = SessionState.getSessionConf();
+    if (location != null) {
+      HiveTableUtil.cleanupTableObjectFile(location, configuration);

Review Comment:
   would we cleanup in case when the operation was canceled?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 829972)
    Time Spent: 1h 40m  (was: 1.5h)

> Use DDLTask to created Iceberg table when running ctas statement
> ----------------------------------------------------------------
>
>                 Key: HIVE-26771
>                 URL: https://issues.apache.org/jira/browse/HIVE-26771
>             Project: Hive
>          Issue Type: Improvement
>          Components: Iceberg integration
>            Reporter: Krisztian Kasa
>            Assignee: Krisztian Kasa
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> When Iceberg table is created via ctas statement the table is created in 
> HiveIcebergSerDe and no DDL task is executed.
> Negative effects of this workflow:
> * Missing table properties: format-version, write.[delete|update|merge].mode
> * Default privileges of the new table are not granted.
> * The new Iceberg table can be seen by other transactions at compile time of 
> ctas.
> * Table creation and table properties are not shown in explain ctas output.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)