[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=838987&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-838987
]
ASF GitHub Bot logged work on HIVE-26809:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/23 01:35
Start Date: 13/Jan/23 01:35
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1040356751
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java:
##########
@@ -61,7 +61,7 @@
import org.apache.orc.impl.TreeReaderFactory.TreeReader;
import org.apache.orc.impl.WriterImpl;
import org.apache.orc.OrcProto;
-
+import org.apache.orc.impl.reader.tree.TypeReader;
Review Comment:
import order is wrong. Imports should be alphabetically sorted
##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##########
@@ -1249,10 +1534,13 @@ public void seek(PositionProvider index) throws
IOException {
}
@Override
- public void nextVector(
- ColumnVector previousVector, boolean[] isNull, int batchSize) throws
IOException {
+ public void nextVector(ColumnVector previousVector,
+ boolean[] isNull,
+ final int batchSize,
+ FilterContext filterContext,
+ ReadPhase readPhase) throws IOException {
Review Comment:
this code doesn't look formatted
##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##########
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
Why is this added in scope of upgrade?
Issue Time Tracking
-------------------
Worklog Id: (was: 838987)
Time Spent: 3.5h (was: 3h 20m)
> Upgrade ORC to 1.8.1
> --------------------
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 4.0.0
> Reporter: Dmitriy Fingerman
> Assignee: Dmitriy Fingerman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
