[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=839509&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839509
]
ASF GitHub Bot logged work on HIVE-26809:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jan/23 05:27
Start Date: 17/Jan/23 05:27
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1071751361
##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##########
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
Ok, that seems to be an improvement or say a bug fix in the ORC project and
we are just implementing our own varient because now the original class is
causing test failures.
This isn't the ideal approach and will backfire in future when we try to
upgrade and the changes in ORC depends on the ones which we ditched.
We should try to adapt to those changes and make sure we don't crash with
those changes in Hive by making hive changes, rather than maintaining a old
version of ORC class at Hive
Issue Time Tracking
-------------------
Worklog Id: (was: 839509)
Time Spent: 5h (was: 4h 50m)
> Upgrade ORC to 1.8.1
> --------------------
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 4.0.0
> Reporter: Dmitriy Fingerman
> Assignee: Dmitriy Fingerman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
