[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=839455&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839455
]
ASF GitHub Bot logged work on HIVE-26809:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/23 17:23
Start Date: 16/Jan/23 17:23
Worklog Time Spent: 10m
Work Description: difin commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1071406567
##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##########
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
This is added as a fix to many failed CI tests that happened without this
fix.
These new classes are classes from Orc project prior to changes to
StringDictionaryTreeReader that were done as part of ORC-1060.
In more detail: Hive implements its own TreeReaderFactory. In ORC project,
the ticket ORC-1060 - "Reduce memory usage when vectorized reading dictionary
string encoding columns" introduced changes to StringDictionaryTreeReader which
were causing exceptions in Hive EncodedTreeReaderFactory when attempting to
upgrade to ORC 1.8.1. To handle that I added changes to Hive's
EncodedTreeReaderFactory to use StringDictionaryTreeReader version from Orc
project prior to changes from ORC-1060.
Issue Time Tracking
-------------------
Worklog Id: (was: 839455)
Time Spent: 4.5h (was: 4h 20m)
> Upgrade ORC to 1.8.1
> --------------------
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 4.0.0
> Reporter: Dmitriy Fingerman
> Assignee: Dmitriy Fingerman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
