[
https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062565#comment-15062565
]
Mohit Sabharwal commented on HIVE-12685:
----------------------------------------
Thanks, [~wzheng]. Couple of comments:
- Better to reference ConfVars.METASTORE_CONNECTION_DRIVER.varname than use
the literal directly.
- Seems like the patch removes some unit test functionality in TestHiveConf.
{code}
// Property defined in hive-site.xml only
- checkHadoopConf("test.property1", null);
- checkHiveConf("test.property1", "hive-site.xml");
{code}
Should we keep the test & move these properties from
common/src/test/resources/hive-site.xml to data/conf/hive-site.xml ?
Also, looks like patch is no longer testing this scenario
{code}
- // Test HiveConf property variable substitution in hive-site.xml
{code}
Perhaps instead of using METASTORE_CONNECTION_DRIVER property for testing, we
can use a dummy property like HIVETESTMODEDUMMYSTATAGGR, so that it doesn't
affect other unit tests?
> Remove invalid property in common/src/test/resources/hive-site.xml
> ------------------------------------------------------------------
>
> Key: HIVE-12685
> URL: https://issues.apache.org/jira/browse/HIVE-12685
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 2.0.0, 2.1.0
> Reporter: Wei Zheng
> Assignee: Wei Zheng
> Attachments: HIVE-12685.1.patch, HIVE-12685.2.patch,
> HIVE-12685.3.patch
>
>
> Currently there's such a property as below, which is obviously wrong
> {code}
> <property>
> <name>javax.jdo.option.ConnectionDriverName</name>
> <value>hive-site.xml</value>
> <description>Override ConfVar defined in HiveConf</description>
> </property>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
