[
https://issues.apache.org/jira/browse/HIVE-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062620#comment-15062620
]
Wei Zheng commented on HIVE-12685:
----------------------------------
[~mohitsabharwal] Thanks for the feedback.
The code below is doing the same thing but serve for different purposes, one to
uses the varname, the other uses the literal.
{code}
// ConfVar overridden in in hive-site.xml
checkHadoopConf(ConfVars.METASTORE_CONNECTION_DRIVER.varname, null);
checkConfVar(ConfVars.METASTORE_CONNECTION_DRIVER,
"org.apache.derby.jdbc.EmbeddedDriver");
// Property defined in hive-site.xml only
checkHadoopConf("javax.jdo.option.ConnectionDriverName", null);
checkHiveConf("javax.jdo.option.ConnectionDriverName",
"org.apache.derby.jdbc.EmbeddedDriver");
{code}
So basically the second part replaces "test.property1".
I agree with you for the last part being removed, I've added that dummy
property to data/conf/hive-site.xml.
Kindly take a look at patch 4.
> Remove invalid property in common/src/test/resources/hive-site.xml
> ------------------------------------------------------------------
>
> Key: HIVE-12685
> URL: https://issues.apache.org/jira/browse/HIVE-12685
> Project: Hive
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 2.0.0, 2.1.0
> Reporter: Wei Zheng
> Assignee: Wei Zheng
> Attachments: HIVE-12685.1.patch, HIVE-12685.2.patch,
> HIVE-12685.3.patch
>
>
> Currently there's such a property as below, which is obviously wrong
> {code}
> <property>
> <name>javax.jdo.option.ConnectionDriverName</name>
> <value>hive-site.xml</value>
> <description>Override ConfVar defined in HiveConf</description>
> </property>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
